Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

during & doDuring with async test #800

Merged
merged 4 commits into from
Jun 28, 2015
Merged

during & doDuring with async test #800

merged 4 commits into from
Jun 28, 2015

Conversation

uzyn
Copy link
Contributor

@uzyn uzyn commented Jun 23, 2015

It's basically whilst and doWhilst with async truth test.

Addresses #156 #602

Will add documentation if maintainer is okay with this PR.

@aearly
Copy link
Collaborator

aearly commented Jun 28, 2015

👍, since several people have asked for it.

Also -- I wonder if the test should be passed a callback of the form function (err, truth) {...} rather than just function (truth) {...}. I realize that most of asyncs predicate-accepting functions expect a callback with just atruth` parameter, but it's something we're going to change in async 2.0.

@aearly aearly added the feature label Jun 28, 2015
@uzyn
Copy link
Contributor Author

uzyn commented Jun 28, 2015

Awesome. Let me update that and the documentation as well.

@uzyn
Copy link
Contributor Author

uzyn commented Jun 28, 2015

Alright. Updated as suggested.

Thanks @aearly

aearly added a commit that referenced this pull request Jun 28, 2015
during & doDuring with async test
@aearly aearly merged commit b58f958 into caolan:master Jun 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants