-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor performance issue #758
Labels
Comments
Thanks for the code review. We'll fix this shortly |
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
when going from 0.9.0 to 0.9.2 I noticed the following change: f5d804f
The problem here, is that q.process() is called "q.concurrency" times. But it should suffice to call it Math.min(q.tasks.length, q.concurrency) times.
OK, this is a minor performance problem. But if q.concurrency happens to be Infinity then it actually produces an endless loop. Which it didn't before. Arguably, "concurrency = Infinity" is not a very sensible case.
The text was updated successfully, but these errors were encountered: