Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example data to the CCDH Model repository #59

Open
gaurav opened this issue Jul 2, 2021 · 1 comment · May be fixed by #124
Open

Add example data to the CCDH Model repository #59

gaurav opened this issue Jul 2, 2021 · 1 comment · May be fixed by #124
Assignees
@gaurav
Labels
linkml representation Issues relating to the LinkML representation of the CRDC-H model
Milestone
Improve CRDCH mod...

Comments

@gaurav
Copy link
Collaborator

gaurav commented Jul 2, 2021 •
edited
Loading

It would be nice to have some example data in this repository, both as part of the documentation (we could actually convert it to Markdown and display it with the docs!) and as a continuous integration test. As per cancerDHC/tools#28, we should have example data in several formats and ensure that they can all be validated.

There is code for doing this included as part of the new LinkML Template Repository, so we should get the code behind this for free once we've implemented #7.
@gaurav gaurav added the linkml representation Issues relating to the LinkML representation of the CRDC-H model label Jul 2, 2021
@gaurav gaurav added this to the CCDH Model, v2.0 milestone Jul 6, 2021
@gaurav gaurav mentioned this issue Jul 6, 2021
Closed
@gaurav
Copy link
Collaborator Author

gaurav commented Sep 9, 2021

As of PR #75, we have a directory into which test files can be placed (https://github.com/cancerDHC/ccdhmodel/tree/main/tests). We will need to figure out how to support validating types other than Diagnosis -- maybe the test file name could be used, e.g. diagnosis_abc123.yaml for diagnoses and bodysite_def456.json for body sites, and so on.

We will get the example files from the Example Data Workflow and from the CCDH Pilot currently in development.

@gaurav gaurav mentioned this issue Sep 16, 2021
Open
@gaurav gaurav self-assigned this Sep 23, 2021
@gaurav gaurav linked a pull request Oct 1, 2021 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaurav gaurav

Labels
linkml representation Issues relating to the LinkML representation of the CRDC-H model
Projects
None yet
Milestone
Improve CRDCH model testing (Phase 3,...
Development

Successfully merging a pull request may close this issue.

Add example data from the Example Data Workflow to use as tests cancerDHC/ccdhmodel
1 participant
@gaurav