Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace relay-pkg.so with relay.so in dockerfiles #100

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Replace relay-pkg.so with relay.so in dockerfiles #100

wants to merge 2 commits into from

Conversation

yatsukhnenko
Copy link
Contributor

All changed dockerfiles successfully build.

@tillkruss
Copy link
Member

It looks like libhiredis_ssl.so is missing in a lot of them: https://github.com/cachewerk/relay/actions/runs/5647328832/job/15297212601

Let's try to use the hiredis package for all containers, instead of installing it from source.

@tillkruss tillkruss linked an issue Jul 24, 2023 that may be closed by this pull request
Retire relay-pkg.so mostly #56
Open
4 tasks
@szepeviktor
Copy link
Contributor

szepeviktor commented Jul 25, 2023 •
edited
Loading

I was experimenting with moving shell commands from Dockerfile to a file.

RUN --mount=type=bind,source=docker-scripts,target=/opt/docker-scripts /opt/docker-scripts/a.sh

https://github.com/szepeviktor/docker-RUN-file
Maybe you find it super useful.

@yatsukhnenko yatsukhnenko mentioned this pull request Aug 1, 2023
Merged
@yatsukhnenko yatsukhnenko marked this pull request as draft August 3, 2023 14:26
@yatsukhnenko yatsukhnenko force-pushed the issue-56 branch 3 times, most recently from 5a2489a to 202f764 Compare August 3, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillkruss tillkruss Awaiting requested review from tillkruss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retire relay-pkg.so mostly
3 participants
@yatsukhnenko @tillkruss @szepeviktor