Commits on Jun 22, 2024

1. wasm-encoder: add method to allow fetching raw Function bytes. …

   When generating function bodies with `wasm-encoder`, it is sometimes
   useful to take the function bytecode, cache it, then reuse it later.
   (For my specific use-case, in weval, I would like to cache
   weval-specialized function bodies and reuse them when creating new
   modules.)
   
   Unfortunately the existing API of `wasm-encoder` makes this *almost* but
   *not quite* easy: `Function` implements `Encode::encode`, but this will
   produce a function body *with* the length prefixed. However there's no
   way to use this unmodified with the next level up the entity hierarchy:
   `CodeSection::raw` wants the function bytes *without* the length
   prefixed.
   
   This is a fairly annoying if small API gap, and otherwise requires
   manually stripping the length prefix, a leb128-encoded integer. It's
   also a small footgun: I naively did not realize this mismatch and tried
   to do the above, only to get perplexing type errors with locals.
   
   This PR adds one method on `wasm_encoder::Function` to return the inner
   bytes directly, and the doc-comment contains an example showing the
   intended use-case.

   

   cfallin committed Jun 22, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ad6d593
   • Browse repository at this point

   Copy the full SHA

   ad6d593 View commit details

   Browse the repository at this point in the history