Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Delete Button deletes multiple items #705

Closed
FloFoer opened this issue Jul 23, 2017 · 3 comments
Closed

Item Delete Button deletes multiple items #705

FloFoer opened this issue Jul 23, 2017 · 3 comments
Assignees
Milestone

Comments

@FloFoer
Copy link
Contributor

FloFoer commented Jul 23, 2017

If i use the the item delete button on the editdevice screen it deletes multiple items instead of the one i pressed delete on if there are multiple items with the same item and type in the items list.
This happens even if they are not consecutive in the list.
Is this intentional?

Maybe in the removeItemxxx methods in app.js it should better be:
$scope.onDevices[i] === anItem
instead of
$scope.onDevices[i].item === anItem.item && $scope.onDevices[i].type === anItem.type
in the loop over xxDevices to determine which one to delete?

@bwssytems
Copy link
Owner

Will take a look

@FloFoer
Copy link
Contributor Author

FloFoer commented Aug 1, 2017

I actually changed that in my code so it's included in my pull request regarding rooms/color.

@bwssytems
Copy link
Owner

Thanks!

@bwssytems bwssytems added this to the V5.0.0 milestone Aug 1, 2017
@bwssytems bwssytems added the bug label Aug 1, 2017
@bwssytems bwssytems self-assigned this Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants