-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created the linux
module to improve the code structure
#130
Conversation
…deb_bundle` into it
…ttings` abd the `BundleSettings` structs
…on` and create a test for it
…in the `generate_desktop_file` test
…in the `test_tar_and_gzip_dir` test
…in the `create_file_with_data` function test
…in the `total_dir_size` function test
…in the `generate_md5sum` function test
I separated the functionality of `generate_icon_files` into 2 functions, One takes care of png icon files: `generate_icon_files_png` and the other takes cares of the rest: `generate_icon_files_non_png. I also extracted out `get_dest_path`
@anas-elgarhy do you need help? I just discovered this project and was thinking that it would be a good idea to accommodate it a little better in order to be able to scale on the other bundle systems out there and I see that you are already working on it |
Yes @SergioRibera, I'm not available now to work on code unfortunately, so I really appreciate if you can help me, and review this pr anaselgarhy#1 or if u fix the conflicts And thanks in advance. |
Merge the base
Add else statement
Separate The Functionality Of `generate_icon_files`
# Conflicts: # src/bundle/linux/deb_bundle.rs # src/bundle/settings.rs
…nd_gzip_dir, create_tar_from_dir, create_file_with_data, total_dir_size, generate_icon_files_png, generate_icon_files_non_png, and generate_md5sum functions
I had to remove the implementation of the But I still need an easy way to create an instance from the |
I think I can help you here too, let me check out that pr and see if I can add some details |
Nice, u can also take a look at the I wonder if this test is not quite important, and we can just remove it |
Resolve the conflicts and merge the master branch
I think it's a good idea to just ignore test |
I can replace the |
@mdsteele Please don't forget to review this sad PR when you have a time |
Ceate a separate
linux
module and separate the common functions into one separated fileThis PR is uncompleted yet, but I opened it to track the progress and to discussion.
I had to implement the
Default
trait for theSettings
and thePackageSettings
and theBundleSettings
structs to create tests, but I'm not sure if this is the beast way or there are the best way to make this without implement theDefault
trait?TODO:
linux
module and acommon
file for Linuxdeb_bundle
intolinux
modulerpm_bundle
intolinux
moduleDefault
traite for theSettings
and thePackageSettings
and theBundleSettings
structs to create testsgenerate_desktop_file
functiontar_and_gzip_dir
function, and refactor it if need itcreate_tar_from_dir
function, and refactor it if need it (covered with thetar_and_gzip_dir
function test)create_file_with_data
function, and refactor it if need ittotal_dir_size
function, and refactor it if need itgenerate_icon_files
function,and create unit-test for itgenerate_md5sum
function from thedeb_bundle.rs
file to thecommon.rs
file, and create a test for it