Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS osx_url_schemes not working #125

Closed
ShayBox opened this issue Dec 11, 2022 · 7 comments
Closed

macOS osx_url_schemes not working #125

ShayBox opened this issue Dec 11, 2022 · 7 comments

Comments

@ShayBox
Copy link

ShayBox commented Dec 11, 2022

[package.metadata.bundle]
identifier = "com.shaybox.launcher-curseforge"
linux_mime_types = ["x-scheme-handler/curseforge"]
linux_exec_args = "%u"
osx_url_schemes = ["curseforge"]

I added this to my Cargo.toml but it doesn't populate any CFBundleURLTypes in the Info.plist file

EDIT: The linux options worked fine, only this mac one doesn't

@ShayBox
Copy link
Author

ShayBox commented Dec 11, 2022

@Kalissaac I'm not on a mac, I can't easily debug this

if !settings.osx_url_schemes().is_empty() {

@Kalissaac
Copy link
Contributor

It seems to be working fine for me on a Mac, let me take a closer look

@ShayBox
Copy link
Author

ShayBox commented Dec 11, 2022

I'm building using github workflows with the macos-latest image
https://github.com/ShayBox/Test/blob/master/.github/workflows/release.yml

@ShayBox
Copy link
Author

ShayBox commented Dec 11, 2022

Oh actually I may have figured it out, I didn't realize this feature was pushed 22 days ago, cargo-bundle from crates.io is 9 months old

@Kalissaac
Copy link
Contributor

Ah, that would probably be it!

@Kalissaac
Copy link
Contributor

For the time being, you should be able to specify this repo in Cargo.toml to build directly from Git

@ShayBox
Copy link
Author

ShayBox commented Dec 11, 2022

That was the problem, sorry about that 👍

@ShayBox ShayBox closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants