Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cargo's --profile option #106

Closed
Kneelawk opened this issue Dec 10, 2021 · 2 comments · Fixed by #107
Closed

Add support for cargo's --profile option #106

Kneelawk opened this issue Dec 10, 2021 · 2 comments · Fixed by #107

Comments

@Kneelawk
Copy link
Contributor

The Issue

Currently, cargo-bundle has no support for a --profile option to allow specifying custom build profiles. Cargo added support for this option in Rust 1.57.0. Adding a --profile option allows users to specify custom profiles for packaging. For example: one profile with normal release optimizations and one profile with release optimizations and link-time optimizations.

The Feature Request

The feature request is that cargo-bundle add an option --profile that takes a single argument, being the name of the custom profile to use. This will invoke the underlying cargo build command with --profile and the custom profile name. The cargo documentation specifies that the build directory used for a custom profile is target/<profile-name> where <profile-name> is the name of the profile being built.

The Pull Request

I am working on a PR to solve this issue. It should be linked once complete.

@vorporeal
Copy link

Hi there - any idea when this change will make it into a published release? Would love to use it but the current published version (v0.5.0) is over a year old, and I'd prefer not to have our build scripts pull from HEAD.

@mdsteele
Copy link
Collaborator

I've just published v0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants