Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples are not up to date #156

Open
fleaz opened this issue Mar 31, 2021 · 2 comments
Open

Examples are not up to date #156

fleaz opened this issue Mar 31, 2021 · 2 comments

Comments

@fleaz
Copy link

fleaz commented Mar 31, 2021

The "examples" submodule currently points to the commit 67f623f which was before the big refactoring, therefore the code is not usable when you install a recent version of the bunq sdk. Especially with this little amount of example code and the lack of proper documentation, at least link to the matching code version of the examples. This will make getting started with this library a bit less frustrating.

Best,
Felix

Steps to reproduce:

  1. Open the 'bunq/sdk_python' repository
  2. Click on the "examples" folder
  3. Try to use any of the code you see

What should happen:

  1. I should see a matching version of the example code

What happens:

  1. I get old example code that is no longer compatible with the library
@BasVerlooy
Copy link

I see this issue is open for more than a year, is there any updated docs/examples which do show the correct references to the SDK. I think it's the most useless example I have seen in a while as nothing works, class filenames have changed, so each reference to context.BunqContext is now context.bunq_context.BunqContext for example.

@jakob11git
Copy link

@BasVerlooy in the examples repository, don't look at the tree of the old commit. switch to HEAD of the most up-to-date branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants