Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Bunkerweb has lua dependencies checked into the repo #1207

Open
1 task done
jgstew opened this issue May 23, 2024 · 0 comments
Open
1 task done

[FEATURE] Bunkerweb has lua dependencies checked into the repo #1207

jgstew opened this issue May 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jgstew
Copy link

jgstew commented May 23, 2024

What's needed and why?

The dependencies should not be in the repo itself and the path were the dependencies are installed should be in the .gitignore file, and the dependencies should be put in place at dev / build time.

See here: https://github.com/bunkerity/bunkerweb/tree/master/src/deps/src

Implementations ideas (optional)

Remove all files and folders under src/deps/src/

Add src/deps/src/ to .gitignore file

Document a process for the install of the dependencies as part of dev or build using a luarocks rockspec file or similar. Have a script to automate the same, which seems like it might already exist in the parent folder.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jgstew jgstew added the enhancement New feature or request label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant