Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command - refactor to use typed interfaces to implement commands for inlets and outlets #6698

Open
nazmulidris opened this issue Oct 20, 2023 · 3 comments
Assignees
Labels

Comments

@nazmulidris
Copy link
Contributor

Following the refactoring of RPC calls, we can now implement all commands using typed interfaces and implemented with a specific RPC client.

For example the Projects trait provides an access to projects, to create/list/delete them. That trait is implemented by the Controller client by making requests to the controller.

The use of the Projects interface can be seen in the following command to create projects.

Desired behavior

Provide similar interfaces for all other commands and remove all the "api helpers" from the ockam_command crate for the following:

  • inlets
  • outlets

All the interfaces and implementations must be part of the ockam_api crate so that the purpose of the ockam_command is only to:

  • get and validate arguments from the command line
  • call the ockam_api crate
  • display progress / reports / outputs / errors

Note

Related epic: #6310


We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

@adiSuper94
Copy link
Contributor

Hi @nazmulidris , If no one has started working on this I'd like to take a crack at this.

@nazmulidris
Copy link
Contributor Author

@adiSuper94 That's awesome, this is all yours. Please let us know if you have any questions as you explore. You can also ask questions on the contributors discord https://discord.gg/RAbjRr3kds

@adiSuper94
Copy link
Contributor

adiSuper94 commented Jun 21, 2024

@nazmulidris / @mrinalwadhwa looks like some work has been done on this ticket as part of #7574, can you confirm if this is still open??
I took a cursory look at it. And maybe the inlets part is still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants