Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust):Breaking changes in upgrading dialoguer crate from 0.10.4 to 0.11.0 #6175

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix(rust):Breaking changes in upgrading dialoguer crate from 0.10.4 to 0.11.0 #6175

merged 1 commit into from
Sep 29, 2023

Conversation

denisyao101
Copy link
Contributor

Fixes #6062 Investigate and fix breaking changes in upgrading dialoguer crate from 0.10.4 to 0.11.0

@denisyao101 denisyao101 requested a review from a team as a code owner September 29, 2023 15:17
@denisyao101 denisyao101 force-pushed the dependabot/cargo/dialoguer-0.11.0 branch from 57f853c to 88db893 Compare September 29, 2023 15:31
@mrinalwadhwa
Copy link
Member

@denisyao101 thank you for spending time on this. A quick fix for the linting error:

could you amend (git commit --amend and git push --force) the commit message to:

fix(rust): breaking changes in upgrading dialoguer crate to 0.11.0

@denisyao101
Copy link
Contributor Author

Ok I will do it.

@denisyao101 denisyao101 force-pushed the dependabot/cargo/dialoguer-0.11.0 branch 2 times, most recently from 2291122 to d3a302e Compare September 29, 2023 16:27
@denisyao101
Copy link
Contributor Author

@mrinalwadhwa done.

@denisyao101 denisyao101 force-pushed the dependabot/cargo/dialoguer-0.11.0 branch from d3a302e to fa95f4f Compare September 29, 2023 16:40
adrianbenavides
adrianbenavides approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge! Thanks @denisyao101 and congratulations on landing your first Ockam PR 🥳

@adrianbenavides adrianbenavides added this pull request to the merge queue Sep 29, 2023
Merged via the queue into build-trust:develop with commit 1ac11f6 Sep 29, 2023
26 checks passed
@mrinalwadhwa mrinalwadhwa added HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged hacktoberfest Apply to issues you want contributors to help with labels Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianbenavides adrianbenavides adrianbenavides approved these changes

Assignees
No one assigned
Labels
hacktoberfest Apply to issues you want contributors to help with HACKTOBERFEST-ACCEPTED To be used when a PR is ready to merge or after it's merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust - Investigate and fix breaking changes in upgrading dialoguer crate from 0.10.4 to 0.11.0
3 participants
@denisyao101 @mrinalwadhwa @adrianbenavides