Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use nix signal feature to allow for dep upgrade #5974

Conversation

hseeberger
Copy link
Contributor

Ref #5936.

@mrinalwadhwa
Copy link
Member

@hseeberger awesome! Thank you, while we review please

The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a PR, this will make the commit as verified.

@mrinalwadhwa
Copy link
Member

Nice the change works! There's a minor formatting/spacing error, if you could address that and accept the CLA, we can merge 👍 https://github.com/build-trust/ockam/actions/runs/6189600055/job/16804078484?pr=5974#step:5:610

@dependabot dependabot bot force-pushed the dependabot/cargo/nix-0.27.1 branch 2 times, most recently from e45a6fa to 78a2408 Compare September 14, 2023 20:50
@mrinalwadhwa mrinalwadhwa changed the base branch from dependabot/cargo/nix-0.27.1 to develop September 15, 2023 05:15
@mrinalwadhwa mrinalwadhwa changed the base branch from develop to dependabot/cargo/nix-0.27.1 September 15, 2023 05:16
@dependabot dependabot bot force-pushed the dependabot/cargo/nix-0.27.1 branch from 78a2408 to 9d702fa Compare September 15, 2023 11:04
Copy link
Member

@metaclips metaclips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little changes and accepting the CLA, and we should merge. Thanks @hseeberger

implementations/rust/ockam/ockam_api/Cargo.toml Outdated Show resolved Hide resolved
dependabot bot and others added 5 commits September 15, 2023 18:48
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.6.0 to 20.6.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from 2.6.2 to 2.7.0.
- [Release notes](https://github.com/swatinem/rust-cache/releases)
- [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md)
- [Commits](Swatinem/rust-cache@v2.6.2...a95ba19)

---
updated-dependencies:
- dependency-name: Swatinem/rust-cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@hseeberger
Copy link
Contributor Author

dependabot bot and others added 2 commits September 19, 2023 18:22
Bumps [nix](https://github.com/nix-rust/nix) from 0.26.2 to 0.27.1.
- [Changelog](https://github.com/nix-rust/nix/blob/master/CHANGELOG.md)
- [Commits](nix-rust/nix@v0.26.2...v0.27.1)

---
updated-dependencies:
- dependency-name: nix
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@hseeberger
Copy link
Contributor Author

Will close this PR and create a new one against develop!

@hseeberger hseeberger closed this Sep 19, 2023
@hseeberger
Copy link
Contributor Author

See #6006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust - Investigate and fix breaking changes in upgrading from nix crate 0.26.2 to 0.27.1
4 participants