Fixes problem with detecting HTTP dump request via HTTP user #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
http:https://http-dump@localhost:8000/user/3/update
^^^
```
fixes #108
---
AI commit text
Updated also the test files and methods dealing with the handling of HTTP dumps, Inspector and Sentry events to include test cases that cover the scenario when an HTTP user is present. The goal of this change is to ensure handling even when an HTTP user is specified. In `AnyHttpRequestDump.php`, a condition was added to check if the HTTP user equals "http-dump", which is anticipated in the newly added scenarios. In the test files, new test methods were written to simulate requests with an HTTP user and additional assertions were made to verify if the events were correctly processed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108
AI commit text
Updated also the test files and methods dealing with the handling of HTTP dumps, Inspector and Sentry events to include test cases that cover the scenario when an HTTP user is present. The goal of this change is to ensure handling even when an HTTP user is specified. In
AnyHttpRequestDump.php, a condition was added to check if the HTTP user equals "http-dump", which is anticipated in the newly added scenarios. In the test files, new test methods were written to simulate requests with an HTTP user and additional assertions were made to verify if the events were correctly processed.