Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Using vue-ray, or js-ray etc - In browser Ray is being blocked by CORS policy #72

Closed
ijpatricio opened this issue Feb 16, 2022 · 4 comments · Fixed by #73
Closed

Using vue-ray, or js-ray etc - In browser Ray is being blocked by CORS policy #72

ijpatricio opened this issue Feb 16, 2022 · 4 comments · Fixed by #73

Comments

@ijpatricio
Copy link

ijpatricio commented Feb 16, 2022

CORS allowed headers are missing.

Still didn't dive into source code. Is this something you would accept a PR?

Or you see this is missing, and easy fix on your end?

image

@butschster
Copy link
Member

Hi @ijpatricio.

Is this something you would accept a PR?
Sure

Try to check CORS on RoadRunner side https://github.com/buggregator/app/blob/master/.rr.yaml#L12
https://roadrunner.dev/docs/http-headers

@HazyAlex
Copy link
Contributor

Hello!
I implemented these changes in #73.

Because I'm currently using the latest docker image (v1.8.4), I patched the older (i.e. non-beta) version here.
Would you be willing to accept these changes and release a new version (e.g. v1.8.5) or are you just focusing on the beta and not taking requests for older versions?

@butschster
Copy link
Member

Hello! I implemented these changes in #73.

Because I'm currently using the latest docker image (v1.8.4), I patched the older (i.e. non-beta) version here. Would you be willing to accept these changes and release a new version (e.g. v1.8.5) or are you just focusing on the beta and not taking requests for older versions?

Hi @HazyAlex

Thank you very much!

@butschster
Copy link
Member

@HazyAlex I can't release 1.8.5 from master branch. You need to create a new PR to 1.x branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants