Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an automated way to catch uppercase file extensions. #34

Open
megalon opened this issue Jan 7, 2020 · 0 comments
Open

Need an automated way to catch uppercase file extensions. #34

megalon opened this issue Jan 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@megalon
Copy link
Member

megalon commented Jan 7, 2020

Issue:
Twice now an uppercase file extension on an image have caused builds to fail.
This is easy to miss visually, and the error does not occur on Windows, so it it's difficult to catch until trying to deploy.
On top of this, if you rename the file extension to lowercase in explorer, Windows doesn't actually update it.

See this failed build log
https://github.com/beat-saber-modding-group/wiki/commit/56f0e9c2de436f84699ec3e82d808e3a5472adee/checks?check_suite_id=387285740
And this PR
#33

Possible solutions:

  • Add this to the build checks
  • Add this to the linter
@megalon megalon added the enhancement New feature or request label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant