Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move more functionality (metrics, transports) to plugins #155

Merged
merged 2 commits into from
Jul 25, 2019
Merged

move more functionality (metrics, transports) to plugins #155

merged 2 commits into from
Jul 25, 2019

Conversation

bsideup
Copy link
Owner

@bsideup bsideup commented Jul 23, 2019 •
edited
Loading

This PR extracts the following plugins:

  • RSocket transport
  • gRPC transport
  • metrics (Prometheus)

Since their implementations can be encapsulated into a plugin, there is no point in having their classes in the main classloader.
It also shows that more transports can be added in future.

Warning: protocol will no longer ship RSocket and gRPC stubs, they have to be generated by the consumer. Consider using the client module that generates them automatically.

@bsideup bsideup added the enhancement New feature or request label Jul 23, 2019
@bsideup bsideup added this to the next milestone Jul 23, 2019
@bsideup bsideup mentioned this pull request Jul 25, 2019
Closed
@bsideup bsideup merged commit 95331b6 into master Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the moar_plugins branch July 25, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lanwen lanwen lanwen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bsideup @lanwen