Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strassen is incorrectly initialized #8

Open
henrikvalter opened this issue Mar 17, 2022 · 0 comments
Open

strassen is incorrectly initialized #8

henrikvalter opened this issue Mar 17, 2022 · 0 comments

Comments

@henrikvalter
Copy link

Strassen should compute a matrix multiplication C = A * B. Right now, matrices A and B are initialized, but then both strassen_main_par and strassen_main_seq are called to compute A = B * C instead. And since C is uninitialized, the result will mostly be 0.

If using validation, compare_matrix will calculate the relative difference between two cells of the parallel and sequential result. For most cells this will be (0-0)/0, which is of course undefined and passes the validation for whatever reason.

A simple fix could be to call the main functions as strassen_main_par(A,B,C,bots_arg_size) instead of strassen_main_par(C, A, B, bots_arg_size) in app-desc.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant