Add "Open in Incognito Window" URL action

brttbndr · Jan 8, 2020 · c45d51e · c45d51e
1 parent 9a718ee
commit c45d51e
Show file tree

Hide file tree

Showing 23 changed files with 43 additions and 1 deletion.
diff --git a/actions.go b/actions.go
@@ -41,6 +41,9 @@ func init() {
  } {
  tabActions[a.Name()] = a
  }
+
+ a := openIncognito{}
+ urlActions[a.Name()] = a
 }
 
 func loadURLActions() error {
@@ -130,7 +133,17 @@ func (a uAction) Run(URL string) error {
  return err
 }
 
+type openIncognito struct{}
+
+func (a openIncognito) Name() string { return "Open in Incognito Window" }
+func (a openIncognito) Icon() *aw.Icon { return iconIncognito }
+func (a openIncognito) Run(URL string) error {
+ mustClient().OpenIncognito(URL)
+ return nil
+}
+
 var (
  _ tabAction = (*tAction)(nil)
  _ urlAction = (*uAction)(nil)
+ _ urlAction = openIncognito{}
 )
diff --git a/extension/alfred.js b/extension/alfred.js
@@ -235,6 +235,9 @@ const Background = function() {
  case 'run-bookmarklet':
  p = self.runBookmarklet(msg.params);
  break;
+ case 'open-incognito':
+ p = self.openIncognito(msg.params);
+ break;
  default:
  console.error(`unknown command: ${msg.command}`);
  self.sendError(msg.id, 'unknown command');
@@ -473,6 +476,16 @@ const Background = function() {
  });
  };
 
+ /**
+ * Handle "open-incognito" command.
+ * @param {string} url - URL to open in a new Incognito window.
+ * @return {Promise} - Promise that resolves to null.
+ */
+ self.openIncognito = url => {
+ console.debug(`open-incognito ${url}`);
+ return browser.windows.create({ incognito: true, url: url });
+ };
+
  /**
  * Return active tab.
  * @param {number} winId - ID of window to get active tab of.

diff --git a/icon.png b/icon.png
diff --git a/icons.afdesign b/icons.afdesign
diff --git a/icons.go b/icons.go
@@ -11,8 +11,9 @@ var (
  iconDocs = &aw.Icon{Value: "icons/docs.png"}
  iconError = &aw.Icon{Value: "icons/error.png"}
  iconHistory = &aw.Icon{Value: "icons/history.png"}
- iconIssue  = &aw.Icon{Value: "icons/issue.png"}
+ iconIncognito = &aw.Icon{Value: "icons/incognito.png"}
  iconInstall = &aw.Icon{Value: "icons/install.png"}
+ iconIssue = &aw.Icon{Value: "icons/issue.png"}
  iconMore = &aw.Icon{Value: "icons/more.png"}
  iconScript = &aw.Icon{Value: "icons/script.png"}
  iconTab = &aw.Icon{Value: "icons/tab.png"}

diff --git a/icons/bookmark.png b/icons/bookmark.png
diff --git a/icons/bookmarklet.png b/icons/bookmarklet.png
diff --git a/icons/docs.png b/icons/docs.png
diff --git a/icons/error.png b/icons/error.png
diff --git a/icons/history.png b/icons/history.png
diff --git a/icons/incognito.png b/icons/incognito.png
diff --git a/icons/install.png b/icons/install.png
diff --git a/icons/issue.png b/icons/issue.png
diff --git a/icons/more.png b/icons/more.png
diff --git a/icons/script.png b/icons/script.png
diff --git a/icons/tab.png b/icons/tab.png
diff --git a/icons/update-available.png b/icons/update-available.png
diff --git a/icons/update-ok.png b/icons/update-ok.png
diff --git a/icons/url.png b/icons/url.png
diff --git a/icons/warning.png b/icons/warning.png
diff --git a/rpc_client.go b/rpc_client.go
@@ -93,6 +93,11 @@ func (c *rpcClient) CloseTabsOther(tabID int) error {
  return c.client.Call("Firefox.CloseTabsOther", tabID, nil)
 }
 
+// OpenIncognito opens a URL in a new Incognito window.
+func (c *rpcClient) OpenIncognito(URL string) error {
+ return c.client.Call("Firefox.OpenIncognito", URL, nil)
+}
+
 // func (c *rpcClient) RunJS(script string) error {
 // return c.client.Call("Firefox.RunJS", script, nil)
 // }

diff --git a/rpc_server.go b/rpc_server.go
@@ -179,6 +179,16 @@ func (s *rpcServer) Downloads(query string, downloads *[]Download) error {
  return nil
 }
 
+// OpenIncognito opens URL in a new incognito window.
+func (s *rpcServer) OpenIncognito(URL string, _ *struct{}) error {
+ defer util.Timed(time.Now(), "open incognito")
+ var r responseNone
+ if err := s.ff.call("open-incognito", URL, &r); err != nil {
+ return err
+ }
+ return nil
+}
+
 // func (s *rpcServer) RunJS(script string, _ *struct{}) error {
 // defer util.Timed(time.Now(), "execute JS")
 // var r responseNone

diff --git a/scripts/Open in Default Application.png b/scripts/Open in Default Application.png