Drop node 6,8 support and add 10,12 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparshithNR
commented
Dec 17, 2019
- current LTS are node 10 and 12
- node 8 is reaching EOL
stefanpenner
requested changes
Jan 7, 2020
stefanpenner
requested changes
Jan 7, 2020
test.js
Outdated
| @@ -77,7 +77,7 @@ describe("FSUpdater", () => { | |||
| }); | |||
|
|
|||
| it("must not be a symlink", () => { | |||
| fs.symlinkSync(".", "tmp/out"); | |||
| fs.symlinkSync(".", "tmp/out", "dir"); | |||
There was a problem hiding this comment.
"dir" seems un-needed, I think node auto-detects.
stefanpenner
requested changes
Jan 7, 2020
| @@ -77,7 +77,7 @@ describe("FSUpdater", () => { | |||
| }); | |||
|
|
|||
| it("must not be a symlink", () => { | |||
There was a problem hiding this comment.
Maybe we can feature detect the failure case, by doing try/catch + test scenario, if that fails, we can simply switch to use junction here. If we go down this path, leave a comment describing when/how etc this work-around can be removed.
|
@SparshithNR windows is still unhappy (you likely know) |
Yeah. using junction didn't resolve the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.