Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/instances naming #21

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Conversation

glasswalk3r
Copy link
Contributor

Just improving the documentation with examples adding name to Dumbbench::Instance sub classes, in order to get a report with properly lines identification.

Also improved the Pod format.

By some reason, the extended tests are failing in my machine, but that also happens with release 0.503 as well.

alceu@temp:~/Projects/dumbbench$ prove -l xt
xt/at_000_eval_vs_sub.t ....... # 
# 1.4961e-01 +/- 1.7e-04
# 1.5569e-01 +/- 1.6e-04
xt/at_000_eval_vs_sub.t ....... 1/2 
#   Failed test at xt/at_000_eval_vs_sub.t line 39.
#     '0.14995'
#         >=
#     '0.15537'
Can't call method "Run" on an undefined value at xt/at_000_eval_vs_sub.t line 64.
# Looks like your test exited with 2 just after 2.
xt/at_000_eval_vs_sub.t ....... Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/2 subtests 
xt/at_000_external_vs_eval.t .. # 
# eval: Ran 23 iterations (3 outliers).
# eval: Rounded run time per iteration (seconds): 1.4575e-01 +/- 1.6e-04 (0.1%)
# cmd: Ran 20 iterations (0 outliers).
# cmd: Rounded run time per iteration (seconds): 1.5006e-01 +/- 7.6e-04 (0.5%)
xt/at_000_external_vs_eval.t .. 1/2 
#   Failed test at xt/at_000_external_vs_eval.t line 39.
#     '0.14607'
#         >=
#     '0.14854'
# Looks like you failed 1 test of 2.
xt/at_000_external_vs_eval.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests 
xt/changes.t .................. ok   

Test Summary Report
-------------------
xt/at_000_eval_vs_sub.t     (Wstat: 512 (exited 2) Tests: 2 Failed: 1)
  Failed test:  1
  Non-zero exit status: 2
xt/at_000_external_vs_eval.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1)
  Failed test:  1
  Non-zero exit status: 1
Files=3, Tests=8, 15 wallclock secs ( 0.03 usr  0.00 sys + 14.18 cusr  0.24 csys = 14.45 CPU)
Result: FAIL

Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks.

@briandfoy briandfoy self-assigned this Jul 7, 2024
@briandfoy briandfoy merged commit 16af087 into briandfoy:master Jul 7, 2024
1 check passed
@briandfoy
Copy link
Owner

I'll look at the tests to see what's going on.

@briandfoy briandfoy added the Type: documentation fix the docs label Jul 7, 2024
@glasswalk3r glasswalk3r deleted the doc/instances_naming branch July 8, 2024 00:24
@briandfoy
Copy link
Owner

Once I get the tests sorted, I'll release these changes as 0.504.

I looked at the failing tests; both were under xt/.

There were two problems:

  1. They wanted to use SOOT to make plots, but did not load SOOT. I made that a conditional based on the availability of SOOT.
  2. The timings tests are not stable. Sometimes one thing is ahead by a millisecond, sometimes it's the other. The errors are an order of magnitude lower so don't affect the numbers that much. I've made these tests TODO. This isn't a fix for the tests, but they shouldn't hold up installation.

@briandfoy briandfoy added the Status: released there is a new release with this fix label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: released there is a new release with this fix Type: documentation fix the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants