Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: 2-address insert command #655

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ed: 2-address insert command #655

merged 1 commit into from
Jun 17, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 16, 2024

  • When testing against GNU and OpenBSD versions, "i" command was with a 2-address prefix was treated as invalid
  • Be compatible and treat effective address as 2nd address if 2 were specified
  • ed commands "a" and "i" are both handled in edInsert(), so this patch covers both
  • test1: "1,2i" --> 2i
  • test2: ",2i" --> 2i
  • test3: "1,2a" --> 2a
  • test4: ",2a" --> 2a

@mknos
ed: 2-address insert command
5c3e23c 
* When testing against GNU and OpenBSD versions, "i" command was with a 2-address prefix was treated as invalid
* Be compatible and treat effective address as 2nd address if 2 were specified
* ed commands "a" and "i" are both handled in edInsert(), so this patch covers both
* test1: "1,2i" --> 2i
* test2: ",2i" --> 2i
* test3: "1,2a" --> 2a
* test4: ",2a" --> 2a
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jun 16, 2024
@briandfoy
Copy link
Owner

changes: if i or a command get two addresses, use the second one as the effective address; GNU/BSD compatibility

@briandfoy briandfoy self-assigned this Jun 17, 2024
@briandfoy briandfoy merged commit bb35774 into briandfoy:master Jun 17, 2024
2 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jul 11, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy