Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Octane 2.x #132

Open
natanparmigianoreis opened this issue Oct 18, 2023 · 2 comments
Open

Compatibility with Octane 2.x #132

natanparmigianoreis opened this issue Oct 18, 2023 · 2 comments

Comments

@natanparmigianoreis
Copy link

Currrently the package is marked as compatible with octane 1.2 explicitly, which makes any Laravel 10.x (which is only compatible with octane 2.x) instalation fall back to bref/laravel-bridge:^1.2 , since that is the last version that does not include the octane requirement in its dependencies.

If nothing "breaks" with the new octane version, it should be a simple version bump.

@natanparmigianoreis
Copy link
Author

Just forked the package and tried it out on a relatively simple application and it seems a simple version bump caused no immediately obvious issues, it surely needs more through testing but right now it seems that it works alright.

https://github.com/natanparmigianoreis/laravel-bridge/blob/master/composer.json

@mnapoli
Copy link
Member

mnapoli commented Oct 18, 2023

That's awesome, thanks for testing. Would you be able to send a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants