Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small gap next to the Brave Shields button #40391

Open
3 of 6 tasks
humanfriend22 opened this issue Aug 9, 2024 · 0 comments
Open
3 of 6 tasks

Small gap next to the Brave Shields button #40391

humanfriend22 opened this issue Aug 9, 2024 · 0 comments
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/Yes

Comments

@humanfriend22
Copy link

Description

There is a small gap next to the Brave Shields button after disabling Rewards.

Steps to reproduce

  1. Disable Brave Rewards
  2. Note the gap next to the button

Actual result

Screen.Recording.2024-08-09.at.3.06.00.PM.mov

Expected result

That gap should probably be reduced to match the one on the left.

Reproduces how often

Easily reproduced

Brave version (brave:https://version info)

Brave: 1.68.128 Chromium: 127.0.6533.73 (Official Build) (arm64)
Revision: 800676fd9ede2eb4174bac98c186e53749c7201f
OS: macOS Version 14.5 (Build 23F79)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@rebron rebron added polish Nice to have — usually related to front-end/visual tasks design A design change, especially one which needs input from the design team priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA/Yes
Projects
Front End
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rebron @humanfriend22