This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix generate_url() AttributeError when using anonymous connections #3734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously generating a URL would fail for anonymous connections (even when using `query_auth=False`), with: `AttributeError: 'AnonAuthHandler' object has no attribute '_hmac_256'` That now works, and in addition the `query_auth=False` parameter is now optional for anonymous connections. Fixes #1540.
|
@mfschwartz - I don't suppose you'd mind reviewing this? :-) |
mfschwartz
reviewed
Jun 28, 2017
|
|
||
| def test_generate_url(self): | ||
| conn = self.connection_class( | ||
| anon=True, |
There was a problem hiding this comment.
Is there another test for that exercises that the non-anonymous case generates a URL as expected?
There was a problem hiding this comment.
Yeah, the existing tests here (since anon defaults to False):
boto/tests/unit/s3/test_connection.py
Lines 67 to 73 in af045f9
boto/tests/unit/s3/test_connection.py
Lines 208 to 214 in af045f9
|
Many thanks! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously generating a URL would fail for anonymous connections (even when using
query_auth=False), with:AttributeError: 'AnonAuthHandler' object has no attribute '_hmac_256'That now works, and in addition the
query_auth=Falseparameter is now optional for anonymous connections.Fixes #1540.