Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction for a mistake in 'last2avg' #16

Open
alexlimh opened this issue May 6, 2021 · 0 comments
Open

Correction for a mistake in 'last2avg' #16

alexlimh opened this issue May 6, 2021 · 0 comments

Comments

@alexlimh
Copy link

alexlimh commented May 6, 2021

Dear BERT-Flow authors,

I notice there's a mistake in your code where you attempt to average the last 2 layers of BERT but instead you average the first and last layer of BERT, which has also been pointed out by issue #11.
Specifically, the for-loop at line 172 of your run_siamese.py file starts from 0 instead of 1, which means that you take the average of the first and the last layer.

As BERT-Flow is a very important line of work in STS, which others need to compare with and build upon, please either correct the mistakes in the paper or update the results using the last 2 layers. However, if I'm wrong please correct me.

Best,
Minghan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant