Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MaybeUninit instead of ManuallyDrop to inhibit the validity invariant of the storage type #3

Merged
merged 4 commits into from
Aug 29, 2019
Merged

Use MaybeUninit instead of ManuallyDrop to inhibit the validity invariant of the storage type #3

merged 4 commits into from
Aug 29, 2019

Commits on Aug 26, 2019

  1. Add some failing tests 

    ```
assertion failed: Some(InlineArray::<usize, [Box<()>; 2]>::new()).is_some()
assertion failed: Some(RingBuffer::<Box<()>>::new()).is_some()
assertion failed: Some(Chunk::<Box<()>>::new()).is_some()
assertion failed: Some(SparseChunk::<Box<()>>::new()).is_some()
```
    @SimonSapin
    SimonSapin committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    7390603 View commit details
    Browse the repository at this point in the history

  2. Use MaybeUninit instead of ManuallyDrop to inhibit the validity invar… 

    …iant of the storage type

https://rust-lang.github.io/unsafe-code-guidelines/glossary.html#validity-and-safety-invariant
    @SimonSapin
    SimonSapin committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    dc1a3df View commit details
    Browse the repository at this point in the history

  3. Use one drop_in_place<[A]> call instead of a loop of drop_in_place<A>… 

    … calls where straightforward

This also takes care of returning early if needs_drop returns false
    @SimonSapin
    SimonSapin committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    7abfc88 View commit details
    Browse the repository at this point in the history

  4. Avoid creating &[A] or &mut [A] with uninitialized A items 

    It is undecided whether the Rust language should make this UB,
so manipulating raw pointers works either way.
    @SimonSapin
    SimonSapin committed Aug 26, 2019
    Configuration menu
    Copy the full SHA
    072f010 View commit details
    Browse the repository at this point in the history