-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
queue.go has still a bug #271
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
func (q *Queue) Tasks() []*Task {
tasks := make([]*Task, len(q.Raw.Items))
for i, t := range q.Raw.Items {
tasks[i] = &Task{Jenkins: q.Jenkins, Queue: q, Raw: &t} //This function is still wrong, because &t will always stay the same pointer. You have to use: &q.Raw.Items[i]
}
return tasks
}
I claim, that there is no test for this function.
The text was updated successfully, but these errors were encountered: