Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy color in HEX, RGBA and HSLA format #43

Merged
merged 10 commits into from
Jan 21, 2021
Merged

Copy color in HEX, RGBA and HSLA format #43

merged 10 commits into from
Jan 21, 2021

Conversation

vildar
Copy link
Contributor

@vildar vildar commented Jan 20, 2021

Issue: #14

srijitcoder
srijitcoder suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@srijitcoder srijitcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Improve this button and dropdown a bit like adding little bid padding, remove border and add border-radius like add button

srijitcoder
srijitcoder suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@srijitcoder srijitcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Use a code editor view for JSON and also prettify it - https://www.npmjs.com/package/react-simple-code-editor

srijitcoder
srijitcoder suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@srijitcoder srijitcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Dark mode button, dropdown and text editor looks little off for dark mode

srijitcoder
srijitcoder previously approved these changes Jan 20, 2021
View reviewed changes
@srijitcoder srijitcoder self-requested a review January 20, 2021 14:12
@srijitcoder srijitcoder merged commit 9427fc0 into blueskyanalytics:master Jan 21, 2021
@srijitcoder srijitcoder linked an issue Jan 21, 2021 that may be closed by this pull request
Color Output Box improvements #8
Closed
@srijitcoder srijitcoder mentioned this pull request Jan 21, 2021
Open
@srijitcoder srijitcoder linked an issue Jan 21, 2021 that may be closed by this pull request
Copy or export colour in different formats #14
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srijitcoder srijitcoder Awaiting requested review from srijitcoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy or export colour in different formats Color Output Box improvements
2 participants
@vildar @srijitcoder