Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_meta validation #27

Closed
joel-bluedata opened this issue Oct 2, 2018 · 3 comments
Closed

config_meta validation #27

joel-bluedata opened this issue Oct 2, 2018 · 3 comments

Comments

@joel-bluedata
Copy link
Member

This needs to be a "dictionary" (object with arbitrary property names) of string values.

In K8s 1.11 and later, we should be able to do this through schema validation i.e.

config_meta:
  type: object
  additionalProperties:
    type: string

However for supporting earlier K8s versions I guess we need to do it in dynamic validation instead. Or we could move to modeling it as an array of sub-objects with explicit key/value properties.

@joel-bluedata
Copy link
Member Author

For reference, the discussion of the relevant issue (with the commit fix noted near the end): kubernetes/kubernetes#59485

K8s 1.11 is now available in GKE deployments if you request it when doing a create, e.g. with --cluster-version=1.11.2-gke.15. It looks like 1.11 is also available in AKS, IBM Cloud, and Digital Ocean.

EKS is still on 1.10 (according to their FAQ). Suuurrrrely they will make 1.11 available soonish?

I would like to just say that our minimum requirement is K8s 1.11, and then not have to worry about dynamic validation for this sort of thing. But the 0.2.0 release is probably too early to do that.

@joel-bluedata joel-bluedata modified the milestones: 0.2.0, 0.3.0 Nov 10, 2018
@joel-bluedata
Copy link
Member Author

EKS now has 1.11 as well.

@joel-bluedata joel-bluedata removed this from the 0.3.0 milestone Nov 14, 2019
@joel-bluedata
Copy link
Member Author

Our minimum requirement is now 1.12, so we can move on this now.

@joel-bluedata joel-bluedata added this to the 0.4.0 milestone Nov 15, 2019
@joel-bluedata joel-bluedata modified the milestones: 0.4.0, 0.5.0 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant