Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase unit tests / code coverage #98

Closed
khufkens opened this issue Jul 28, 2022 · 4 comments
Closed

Increase unit tests / code coverage #98

khufkens opened this issue Jul 28, 2022 · 4 comments

Comments

@khufkens
Copy link
Member

R6 implementation shifted things about needs more unit tests to cover functions.

  • wf_transfer()
  • ...
@eliocamp
Copy link
Collaborator

eliocamp commented Aug 1, 2022

wf_transfer() needs to be better adapted to the new implementation, I think. Ideally, it could only be url$transfer() since all the work is donde in the class. However, right now it has a lot of code to cover the case of url being a.. you know, an URL 🤣. Is this needed?

If it is, then I think it should change a bit. Instead of doing all that work, it should just create a new request object with the hardcoded URL (no request$submit() needed) and then call request$transfer().

@khufkens
Copy link
Member Author

khufkens commented Aug 1, 2022

I think that we should keep the wf_transer() function even if it isn't used anymore. People might use it in their custom workflows and it can be kept, if not just as a wrapper for request$transfer(). But yes, for consistency a formal request$transfer() would probably be consistent with the new scheme.

@khufkens
Copy link
Member Author

Bumped things up (69%), but gui related calls and error trapping which can't be triggered (e.g. servers offline etc) pull coverage down. Most important parts are now tested though.

@khufkens
Copy link
Member Author

FYI. Think things are now set for release 1.4!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants