Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds explicit service to get_key #47

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Adds explicit service to get_key #47

merged 1 commit into from
Dec 23, 2019

Conversation

eliocamp
Copy link
Collaborator

@eliocamp eliocamp commented Dec 9, 2019

This fixes #46.

@codecov-io
Copy link

codecov-io commented Dec 9, 2019 •
edited
Loading

Codecov Report

Merging #47 into master will decrease coverage by 65.63%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #47       +/-   ##
===========================================
- Coverage   84.58%   18.94%   -65.64%     
===========================================
  Files          14       14               
  Lines         532      533        +1     
===========================================
- Hits          450      101      -349     
- Misses         82      432      +350
Impacted Files Coverage Δ
R/wf_request.R 0% <0%> (-78.95%) ⬇️
R/wf_product_info.R 0% <0%> (-100%) ⬇️
R/wf_delete.R 0% <0%> (-100%) ⬇️
R/wf_check_request.R 0% <0%> (-96.56%) ⬇️
R/wf_datasets.R 0% <0%> (-96.16%) ⬇️
R/wf_services.R 0% <0%> (-94.74%) ⬇️
R/wf_user_info.R 0% <0%> (-93.75%) ⬇️
R/wf_transfer.R 0% <0%> (-81.82%) ⬇️
R/wf_set_key.R 0% <0%> (-65.39%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dabcf2f...0ed2fe6. Read the comment docs.

@eliocamp eliocamp mentioned this pull request Dec 20, 2019
Closed
@khufkens khufkens merged commit b843d21 into bluegreen-labs:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keyring fails with env backend.
3 participants
@eliocamp @codecov-io @khufkens