Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetCDF should not be forced (wf_request) #4

Closed
retostauffer opened this issue Jan 23, 2019 · 4 comments
Closed

NetCDF should not be forced (wf_request) #4

retostauffer opened this issue Jan 23, 2019 · 4 comments

Comments

@retostauffer
Copy link
Contributor

The wf_request function forces the NetCDF format. I don't think that this should be done as some people (including myself) are using good old grib and some data sets (e.g., regional models (TIGGE)) cannot be converted to NetCDF.

@retostauffer
Copy link
Contributor Author

Related to issue #5 #6

@khufkens
Copy link
Member

This was mainly done because support for grib is poor in R. Wouldn't make sense to provide data which can't be used in R. This is in part solved with the stars package now included in Suggests (would be useful for examples).

I removed this forced conversion but in the same line of thinking removed a lot of the custom error traps you put in, relying solely on the errors of the respective services (which might occur).

@eliocamp
Copy link
Collaborator

Hi! The documentation in wf_request() still states that it forces NetCDF() downloads. I can make a PR removing those lines, if you'd like.

@khufkens
Copy link
Member

All contributions to lighten the load are more than welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants