-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rOpenSci review + (JOSS) paper #24
Comments
I don't have any simple examples handy at the moment. I've used the data for a paper I'm preparing that I think is too inside baseball. Here's an idea that might be a stretch: would it be possible to have this package listed in the ECMWF webpage in some capacity? Probable not, because it would mean a level of official support they are probably not willing to give willy nilly. But maybe? |
@eliocamp I was looking at your metR package and thought it would make a fitting example, visualizing things. Even more so as I was dealing with wind data the past week for my birding friend (calculating least resistance flight paths using windr etc). Endorsement by ECMWF will likely not happen due to liabilities etc. But, might be worth a shot at some point (certainly past a next release). |
Hy @khufkens
These things would not be too tricky to write, but may be too simple from a scientific perspective (state of the art research). Thus, I am not sure whether or not one should use such illustrative but simplified examples? All best, |
I can do some simple visualisation examples with regression maps and the like. I'll add some principal component calculations. |
Hi @retostauffer, @eliocamp these are all wonderful examples! I would argue that cutting edge research is not needed - too hard to keep up with things anyway. I think the point would be to provide a starting point for analysis and code development. So thinking about intermediate data to analysis might also be helpful (say a general threshold based function - or how to efficiently tackle this). So although the trend estimation might not be perfect I think it is still a good starting point for most, and still valid (with a bit of a disclaimer). The rest of the examples are also wonderful. |
Where should these examples be located? Vignettes should be the obvious place, but then we should add the extra tools needed for analysis as dependencies (in suggests). |
If things are more substantial in terms of custom functions I would suggest to put them in the ecmwfrExtra repo (https://github.com/khufkens/ecmwfrExtra) together with any proposals written to gather support. The vignettes in the ecmwfr package should cover basic usage, simple long term means etc would still be ok (i.e. how is the data structured and how do I query a subset). The moment you hit more complex cases things will get muddy, best to put it elsewhere with a proper introduction to the problem (meteorological, hydrological, ecological etc). This would also allow to borrow some visuals from these vignettes and show some initial code development in any dependent proposals (as the one in place or maybe in the future for other work). Not sure it applies, but feel free to run with the idea elsewhere as well. |
Perfect. I'll PR that repo with examples, then! |
Currently functionality is good, and working toward the ecmwfrExtra will provide considerable context, and worked examples, so writing a paper will be easier (or vice versa). It might be time to think about how to move forward with this. Thoughts, @jwagemann @eliocamp @retostauffer?
worked examples + data integration
From my part I have these ideas:
The text was updated successfully, but these errors were encountered: