-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong version in curl config? #130
Comments
This is the version which "works". The comment might not be correct in this sense. I would leave as is unless strong counter indications. |
Sounds good. In my experience, using HTTP/1.1 is less prone to weird curl errors, among other fail cases, so doing what works and using the simpler method, as you say, is better. The comment and the unintuitive enumeration caught my eye so I just wanted to share what I'd learned at what has most recently bitten me 😅 and try to prevent it biting someone else. |
I stumbled upon this while looking for something else. It looks like the code intends for the use of the HTTP/2 protocol, based on the comment, but I believe that the code is actually specifying HTTP/1.1.
Link:
ecmwfr/R/zzz.R
Line 142 in 534e988
Somewhat confusingly, it seems the
curl
uses an enum for specifying thathttp_version
argument. My read could be wrong, but thecurl
headers source code indicates that the value of 2 corresponds to HTTP/1.1, while a value of 3 would indicate HTTP/2.I've been tracking this issue in an unrelated project, and I am by no means a
curl
expert. I do have some experience with numerical weather prediction, though, which is part of what caught my eye when I saw a search hit for this line in your code.The text was updated successfully, but these errors were encountered: