Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MumbleLink disconnecting when using Mumble for positional audio #930

Open
Metallis opened this issue Nov 13, 2023 · 2 comments
Open

MumbleLink disconnecting when using Mumble for positional audio #930

Metallis opened this issue Nov 13, 2023 · 2 comments

Comments

@Metallis
Copy link

if (this.RawClient.Tick > _prevTick) {

When using Mumble for positional audio, in addition to Blish HUD, going through 2 loading screens seems to disconnect MumbleLink from GW2 temporarily and when the link "light" returns, Blish still doesn't respond properly. Currently the suspect is the linked section starting at 93 and current suspicion is that Blish doesn't know how to handle it when a disconnect happens without the game closing, causing the _prevTick to be GREATER than this.RawClient.Tick and "hangs" until the normal criteria is met. Maybe a case statement that also sets _prevTick to be equal to this.RawClient.Tick could handle this, but I have no idea if that could potentially have other effects or cause float errors or anything.

Contact DragonHeart996 if you need someone to test it.

@Metallis
Copy link
Author

Additional info from DragonHeart: Mumble itself seems to use

if (lm.uiTick != last_tick) {
            last_tick      = lm.uiTick;

@Metallis
Copy link
Author

Metallis commented Jan 15, 2024

DragonHeart has made a forked version and it seems to work with just this one line change! Of note, it may cause issues with making Blish falsely detect TacO as running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant