-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module load order is not defined #801
Labels
feature
New feature or request
Comments
We will want to decouple the loading of modules from the stage that we enable the modules so that we can:
This also means that we can't load all modules at the same time if there are dependencies. Secondary modules will need to wait until their dependencies finish loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Modules currently load in a somewhat undetermined order. In reality it's dictated by the order returned by windows when we enumerate the modules directory, but this isn't strictly defined anywhere and just results in modules loading sorted by their namespace alphabetically (as modules are always saved using their namespace as the filename).
Further, modules which are launched via the launch flag will run first which can cause slight discrepancies between debug and standard launch behavior, and we want to avoid that where possible.
Finally, modules can depend upon other modules. We do enforce this partially for users (preventing them from enabling when a module dependency is not met), but when automatically enabling modules, we don't enforce the dependency load order. This is especially obnoxious when creating a module which depends on another module as the developed module will always load first.
Since modules can be enabled or disabled at any time, this can become problematic - especially when module updates are involved.
Ultimately, we have two needs:
The text was updated successfully, but these errors were encountered: