-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Birdseye Autolayout #6734
Birdseye Autolayout #6734
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
dca0456
to
c0c3ff2
Compare
Did you test this with portrait cameras as well? |
No I haven't tested with portrait, I think it would work fine if the birdseye resolution was set to portrait but if it was the default horizontal I don't think this would allow portrait to take the full screen |
Can confirm, a vertical camera gets squished into a box suitable for a normal horizontal camera. I think it would be nice to have the option for a vertical camera to take up two horizontal places. Example:
|
@JeffWDH how many cameras are in your layout? behavior will be different if it is 3+ |
@NickM-27 I was testing with two, one vertical and one horizontal. I just tested with one vertical and two horizontal and a similar layout happens, the vertical one gets squished into a.box suitable for a horizontal camera. |
Thanks, I have fixed this #6779 |
@NickM-27 Excellent, thank you very much for all the work you put into this project. |
This is not working well with my one portrait camera. It's getting squished down tiny. I'm on 0.13.0-FF90DB3. I am seeing a couple log lines about |
@ccutrer Have you read the conversation above? |
Yes. In particular
But my screenshot looks like my portrait camera is somehow getting squished down to 1/4 the size of a box suitable for a landscape camera, not one. I also saw a similar thing when I had ~10 active cameras. I'm happy to test that PR out though. Are docker images not automatically generated for PRs? |
it's the same issue, fixed in the PR. It is also worth noting that the cameras that come first in the order are given higher priority as far as sizing goes. So if you want the portrait camera to be higher size you should order it to be one of the first ones in the layout |
dev-7e5abe7-tensorrt @NickM-27 - it's better but still not optimal: I've tried reordering my cameras in the "cameras:" section but it doesn't seem to change the layout. |
yeah, you need to set the birdseye order with
|
That makes much more sense than what I was doing :) I ordered the vertical camera 0, and the other two 1 & 2. The birdseye stream is broken now and get the following errors in the log:
|
Interesting, I'll take a look at that but for now maybe try increasing the birdseye resolution slightly |
what is the resolution on the portrait cam? |
Detect (W/H): 720/1280 |
Will the changes made here give the potential for Birdseye to only display one camera? Ie. Only display the camera with the last motion, so you see the current/last motion camera better and not split? |
Not sure I understand the question, birdseye always showed 1 camera if only 1 camera fit the activity type. These PRs only change the layout not the birdseye behavior itself |
Thanks @NickM-27 , I was hoping that the changes may allow for the display to only ever show one camera. The last camera that detected motion or an object. So that there is ever only one larger display but it would change depending on the most recent motion or object detection. As in, there was an option that this new PR gives the function of saying, only display x amount of cameras at any one time. |
That would be a separate feature request although I don't think it would be difficult to implement |
Thanks @NickM-27 , I thought that part of it may be out of scope of this PR. However, given the new changes that this will allow for the camera view/size, etc, I thought they may go well together. I will create a new issue/feature request |
So out of curiosity (tried testing real fast but couldn't get Unraid to download dev branch), if I have 6 x 16:9 feeds, and 2 4:3 feeds. would this be able to make 2 columns x 3 rows of 16:9 and 1 column 2 rows of 4:3 to fill the screen? |
It would depend on the order of the cameras |
This PR works to attempt to fill in the full birdseye canvas with camera as opposed to the grid layout. This is especially useful for cameras like my hikvision panoramic which essentially takes up the same space as 2 16:9 cameras. There are a few behavior changes relative to the previous implementation: