-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add descriptions to events #3876
Comments
I like this idea as it avoids having to re-watch the clip to figure it out. It is also good for documenting things if it is related to a police or insurance issue. |
It also needs to be searchable |
@NickM-27, did not notice this open issue but did a first pass at adding this: irakhlin@9b1f1ac outside of renaming the field from description to user_description, what other additional could be made? Would this be entertained as a pull request? |
I'm not sure if this will be considered currently, we have major changes coming to the UI in 0.14 and I don't know where these descriptions would fit in to that. I'd suggest waiting until those changes are more built out then perhaps we can revisit this idea |
Sounds good, I will maintain the added functions for now on my own branch to help with adding more functionality to amblegpt. Regardless feel free to let me know here when this feature would be entertained for merging in regardless of what code changes need to be made. Thus far I've added it to the event section, and have it expand the message on event selection, along with a dedicated search box to queries across the "description" field.. |
now that we are further along with the UI, I don't think this feature directly makes sense. exports will be the way to mark a review as important (retain it indefinitely) and name it what makes sense. Then it can be searched in the new UI |
Describe what you are trying to accomplish and why in non technical terms
When events occur, especially with the new event favoriting, you may want to add a short description. This description will be shown in the UI so it is easy to skim and remember why a clip was favorited and is important.
Describe the solution you'd like
Add a
user_description
field to the DB and show the description as well as button to edit in the UI.Describe alternatives you've considered
Could save descriptions elsewhere
The text was updated successfully, but these errors were encountered: