Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export broken in dev branch #11785

Closed
sorenisanerd opened this issue Jun 6, 2024 · 3 comments
Closed

Export broken in dev branch #11785

sorenisanerd opened this issue Jun 6, 2024 · 3 comments

Comments

@sorenisanerd
Copy link
Contributor

On the dev branch (commit d2787d4), I see this error:

Exception in thread Thread-2132:
Traceback (most recent call last):
  File "/usr/lib/python3.9/threading.py", line 954, in _bootstrap_inner
    self.run()
  File "/opt/frigate/frigate/record/export.py", line 172, in run
    thumb_path = self.save_thumbnail(export_id)
  File "/opt/frigate/frigate/record/export.py", line 77, in save_thumbnail
    ) < datetime.datetime.now().astimezone(datetime.timezone.dst).replace(
TypeError: tzinfo argument must be None or of a tzinfo subclass, not type 'method_descriptor'

frigate/frigate/record/export.py

Line 77 in d2787d4

) < datetime.datetime.now().astimezone(datetime.timezone.dst).replace(

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 6, 2024

Issues should not be used for this, please submit a bug

@NickM-27 NickM-27 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 6, 2024
@sorenisanerd
Copy link
Contributor Author

Uh... Issues are bugs. Does Frigate use an external bug tracker?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 6, 2024

There is a bug template linked in the issue creation page. In any case, this bug is fixed in a PR that was just put up

sorenisanerd added a commit to sorenisanerd/frigate that referenced this issue Jun 6, 2024
@sorenisanerd
Fix typo in record/export.py
50aea99 
A recent change added a call to
`datetime.datetime.now().astimezone(datetime.timezone.dst)`. The
`datetime.timezone.dst` argument should be `datetime.timezone.utc`.

Fixes blakeblackshear#11785
@sorenisanerd sorenisanerd mentioned this issue Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typo in record/export.py sorenisanerd/frigate
2 participants
@sorenisanerd @NickM-27