From 3e1861e2ce0443557e18900505872718d0156ca9 Mon Sep 17 00:00:00 2001 From: Nicolas Mowen Date: Wed, 12 Jun 2024 16:48:54 -0500 Subject: [PATCH] Correctly update segment data (#11922) --- frigate/review/maintainer.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/frigate/review/maintainer.py b/frigate/review/maintainer.py index b01baf1bf6..abf5029fb1 100644 --- a/frigate/review/maintainer.py +++ b/frigate/review/maintainer.py @@ -194,10 +194,9 @@ def update_segment( camera_config: CameraConfig, frame, objects: list[TrackedObject], + prev_data: dict[str, any], ) -> None: """Update segment.""" - prev_data = segment.get_data(ended=False) - if frame is not None: segment.update_frame(camera_config, frame, objects) @@ -240,6 +239,7 @@ def update_existing_segment( """Validate if existing review segment should continue.""" camera_config = self.config.cameras[segment.camera] active_objects = get_active_objects(frame_time, camera_config, objects) + prev_data = segment.get_data(False) if len(active_objects) > 0: should_update = False @@ -288,7 +288,7 @@ def update_existing_segment( frame_id, camera_config.frame_shape_yuv ) self.update_segment( - segment, camera_config, yuv_frame, active_objects + segment, camera_config, yuv_frame, active_objects, prev_data ) self.frame_manager.close(frame_id) except FileNotFoundError: @@ -302,7 +302,7 @@ def update_existing_segment( ) segment.save_full_frame(camera_config, yuv_frame) self.frame_manager.close(frame_id) - self.update_segment(segment, camera_config, None, []) + self.update_segment(segment, camera_config, None, [], prev_data) except FileNotFoundError: return