redis-cluster: create STS per Master/Replica pair

[nefelim4ag]

Redis cluster:
Currently when cluster provisioned all nodes randomly joined and we can't correctly handle podAntiAffinity in cluster.

So my proporse doing something like:
Sts per group of hosts, example:
numNodes: 8
replica: 2

M - redis-0-0
S - redis-0-1
M - redis-1-0
S - redis-1-1
M - redis-2-0
S - redis-2-1
M - redis-3-0
S - redis-3-1

So that's look easy to add new nodes, manage replicas and do any sort of internal antiAffinity
As we have labels on STS pods, we can continue use current code to build up cluster

But i'm not sure about replica migration behaviour

[miguelaeh]

Hi @nefelim4ag ,
Thank you very much for the request. We are always happy to receive PRs of that type. Would you like to create one adding such feature?

[nefelim4ag]

I will try, when i have a bit free time

[plachta11b]

Hi, I would prefer labelling pods as redis-cluster/replication: master or redis-cluster/replication: replica and having separate label for shard/partition as redis-cluster/shard: 0 or redis-cluster/shard: master-0-hash to avoid wildcards in podAntiAffinity/topologySpreadConstraints. So redis-2-1 would be something like redis-cluster/replication: replica, redis-cluster/shard: 2. I don't have much free time this month but i would love to help with this PR.

EDIT: it should be app.kubernetes.io/component: master and app.kubernetes.io/component: replica as already implemented in non cluster version.

[github-actions]

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

[github-actions]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.