[bitnami/redis] Service port rename for istio protocol selection #5679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from upstream
Update for fix to linter
MichaelHudgins
changed the title
carrodher
approved these changes
Mar 5, 2021
Signed-off-by: Bitnami Containers <[email protected]>
|
I have just updated the bitnami images with the latest known immutable tags:
|
1 task
miguelaeh
pushed a commit
to miguelaeh/bitnami-charts
that referenced
this pull request
Apr 6, 2021
…nami#5679) * Service names changed for istio protocol selection * [bitnami/redis] Update components versions Signed-off-by: Bitnami Containers <[email protected]> Co-authored-by: Bitnami Containers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Modifies the default service port name for redis services to allow for istio sidecar injection and mtls.
Benefits
Allows for the use of istio service mesh with sidecar injection and mtls enabled without post chart modifications to the services.
Applicable issues
Additional information
With the current configuration of the chart istio does not create a direct endpoint for each redis pod. This means that direct ip communication ends up hitting the PassthroughCluster. With the modification of service name a direct ip endpoint is created and istio with mtls can be used.
How istio protocol selection works can be seen here:
https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/
Chart.yamlaccording to semver.[bitnami/chart])