Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/kafka] fix: Mount kafka_jaas.conf in controller statefulset for kraft migration #27610

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

ph311o
Copy link
Contributor

@ph311o ph311o commented Jul 1, 2024

Description of the change

During testing migration to kraft mode I recognized that the controller needs also a VolumeMount to the kafka_jaas.conf file to be able to properly connect to Zookeeper.

Benefits

You can now migrate an external sasl authenticated zookeeper.

Possible drawbacks

None

Applicable issues

Additional information

None

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added kafka triage Triage is needed labels Jul 1, 2024
@github-actions github-actions bot requested a review from carrodher July 1, 2024 08:30
@carrodher
Copy link
Member

carrodher commented Jul 1, 2024

Thanks for your contribution, please note a new version was released in the meantime, see #27613. Can you please bump the chart version again? Thanks

@ph311o ph311o force-pushed the fix/kafka-controller-jaas branch from d8b3f3a to 96810aa Compare July 2, 2024 07:07
@ph311o
Copy link
Contributor Author

ph311o commented Jul 2, 2024

@carrodher Bumped Version.

Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Jul 2, 2024
@github-actions github-actions bot removed the triage Triage is needed label Jul 2, 2024
@github-actions github-actions bot removed the request for review from carrodher July 2, 2024 07:30
@github-actions github-actions bot requested a review from fmulero July 2, 2024 07:30
Copy link
Collaborator

@fmulero fmulero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ph311o for your contribution!

Nice catch! LGTM

@fmulero fmulero merged commit fcf03f8 into bitnami:main Jul 2, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kafka solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/kafka] Setup of sasl authentication to external zookeeper during Kraft-Migration
4 participants