Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/apisix] Add IngressClass for Ingress Controller #27568

Merged
merged 8 commits into from
Jun 28, 2024
Merged

[bitnami/apisix] Add IngressClass for Ingress Controller #27568

merged 8 commits into from
Jun 28, 2024

Conversation

juan131
Copy link
Contributor

@juan131 juan131 commented Jun 27, 2024

Description of the change

This PR adds the missing IngressClass manifest for the APISIX Ingress Controller.

Benefits

Users can choose to use the APISIX Ingress Controller via IngressClassName

Possible drawbacks

None

Applicable issues

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 27, 2024
rafariossaa
rafariossaa previously approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitnami-bot
Update CHANGELOG.md
fceb87c 
Signed-off-by: Bitnami Containers <[email protected]>
@bitnami-bot
Update README.md with readme-generator-for-helm
c67f9b8 
Signed-off-by: Bitnami Containers <[email protected]>
juan131 and others added 3 commits June 28, 2024 08:53
@juan131
fix: simplify condition
62be6aa 
Signed-off-by: juan131 <[email protected]>
@bitnami-bot
Update CHANGELOG.md
deeaef8 
Signed-off-by: Bitnami Containers <[email protected]>
@juan131
fix: ingress_version
d22227c 
Signed-off-by: juan131 <[email protected]>
rafariossaa
rafariossaa previously approved these changes Jun 28, 2024
View reviewed changes
rafariossaa
rafariossaa previously approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juan131 juan131 merged commit 40b3153 into bitnami:main Jun 28, 2024
12 checks passed
@juan131 juan131 deleted the feat/apisix-ingressclass branch June 28, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafariossaa rafariossaa rafariossaa approved these changes

Assignees

@rafariossaa rafariossaa

Labels
apisix bitnami solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/apisix] missing ingressClass resource KIND
3 participants
@juan131 @rafariossaa @bitnami-bot