Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the rust-bitcoin types in their own crate #556

Open
thunderbiscuit opened this issue Jun 11, 2024 · 1 comment
Open

Publish the rust-bitcoin types in their own crate #556

thunderbiscuit opened this issue Jun 11, 2024 · 1 comment

Comments

@thunderbiscuit
Copy link
Member

The types that reside in the current bitcoin.rs file are the ones that come from the rust-bitcoin crate. I have made good progress to pull those out of this repo and allow them to live in a separate crate and simply be imported. This has serious advantages in the long run:

  • It allows other bitcoin projects that build language bindings using uniffi to leverage these types without re-writing them and maintaining them themselves
  • If other projects also use those types, it brings more eyes and review on the codebase
  • We potentially pool the burden of development and exposing of more rust-bitcoin types among more projects
@thunderbiscuit
Copy link
Member Author

I have be quite successful at migrating Kotlin and Python to this temporary crate. You can see the PR here.

My current issue is around how to build the Swift package in a way that types from the bdk library can see and use the types from the rust-bitcoin library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant