Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to the procedural macros system of uniffi-rs #300

Open
thunderbiscuit opened this issue Jan 26, 2023 · 4 comments
Open

Migration to the procedural macros system of uniffi-rs #300

thunderbiscuit opened this issue Jan 26, 2023 · 4 comments

Comments

@thunderbiscuit
Copy link
Member

I'm opening this issue to keep track of documentation, references, and discussions around the migration to the new uniffi-rs system.

  1. Documentation page on using proc-macros: here
  2. Issue on readiness of migration and further documentation: here
  3. PR for the 0.23.0 migration: Bump uniffi-rs dependency to 0.23.0 #299
This was referenced Jan 31, 2023
@aki-mizu
Copy link

It seems rust-nostr already successfully migrated their ffi part to proc-macro
rust-nostr/nostr#204

@reez
Copy link
Collaborator

reez commented Apr 30, 2024

Thunder how interested are you in doing this at the current moment, just wondering what you're current thoughts would be for this

@thunderbiscuit
Copy link
Member Author

Looking into it now. I'm not sure if we'd be able to migrate everything or if some things would stay in the UDL and some would be proc macros.

But the one prerequisite to this is that we use the --library flag to create the library, which is recommended anyway and is a good move forward no matter what if we can do it, so I think we can start with that and see where it leads us.

@reez
Copy link
Collaborator

reez commented Apr 30, 2024

awesome, thanks for those thoughts, and --library makes sense to start like you're saying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants