Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder contents was not excluded when exclude pattern was */.AppName/files/* #1215

Open
slrslr opened this issue Jan 14, 2022 · 6 comments
Open
Labels
Documentation GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues

Comments

@slrslr
Copy link

slrslr commented Jan 14, 2022

Hello,

exclude pattern is: */.AppName/files/*

i expected that it will exclude content of the /home/me/.AppName/files folder
but files/directories inside it was backed up seemingly

i have not wanted to use full path, like Back In Time is doing when i right click that folder called "files" and select Add to Exclude.

@daveTheOldCoder
Copy link

daveTheOldCoder commented Jan 16, 2022

Try /home/me/.AppName/files to exclude the folder and its contents, or /home/me/.AppName/files/* to exclude the folder's contents but not the (empty) folder.

.AppName/files and .AppName/files/* may work too, but they would also match folders with that pattern outside of /home/me.

When the path starts with a /, it's interpreted as an absolute path.

@slrslr
Copy link
Author

slrslr commented Jan 19, 2022

thx, yes, this works:
.AppName/files/*
though this does not:
*/.AppName/files/*
which is a bit confusing and a reason why i have created this issue, if this something that can be internally made working

@daveTheOldCoder
Copy link

daveTheOldCoder commented Jan 20, 2022

I think the include/exclude patterns are simply passed along to the rsync command, so that command's behavior determines how they work.

@octohedron
Copy link

Would be nice to display this information in the exclude dialog

@buhtz
Copy link
Member

buhtz commented Sep 22, 2022

Would be nice to display this information in the exclude dialog

You mean as a "help text"? For example a tool tip or something like this?

@octohedron
Copy link

I would make it more explicit, i.e. without having to look for any additional help or tooltip, something like this in the dialog.

Example: "node_modules/*" would exclude all node_modules folders in the system.

Or even better

There's no need to add anything before a folder to exclude it system wide, e.g. "node_modules/*" would exclude all node_modules folders in the system.

@buhtz buhtz added this to the 1.3.5 / 1.4.0 milestone Mar 19, 2023
@buhtz buhtz added GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues
Projects
None yet
Development

No branches or pull requests

5 participants