Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering '.' in profile "host" and/or "user" breaks restore #1001

Open
DonEdwards opened this issue May 18, 2019 · 1 comment
Open

Entering '.' in profile "host" and/or "user" breaks restore #1001

DonEdwards opened this issue May 18, 2019 · 1 comment
Labels
Bug Qt Qt bugs, code or features

Comments

@DonEdwards
Copy link

For a single-user single-system environment, it makes sense to configure backintime profiles with dots in the "host" and "user" fields - skipping two levels of directories which, in this specific context, serve no function.

However, with this configuration, "restore" writes to /{profile]/{datetimestamp}/backup (copying the rest of the file path). "restore to" similarly writes to {wherever you tell it}/{profile}/{datetimestamp}/backup. {datetimestamp} in this referring to the snapshot being restored from.

@emtiu
Copy link
Member

emtiu commented Sep 24, 2022

Hi, thanks for your report! Your feature request is identical to #1304, and we're tracking that there. However, entering . in those path fields shouldn't be allowed at all, because it leads (as you encountered) to all sorts of unexpected breakage.

So it's best if we sanitize user input there, and I'm keeping this Issue open to remind us.

@emtiu emtiu added the Bug label Sep 24, 2022
@emtiu emtiu changed the title Single-user simplification doesn't restore well Entering '.' in profile "host" and/or "user" breaks restore Sep 24, 2022
@buhtz buhtz added this to the 1.3.4 milestone Mar 19, 2023
@buhtz buhtz added the Qt Qt bugs, code or features label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Qt Qt bugs, code or features
Projects
None yet
Development

No branches or pull requests

3 participants